Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump myskoda to 0.17.2 #562

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Bump myskoda to 0.17.2 #562

merged 4 commits into from
Jan 14, 2025

Conversation

WebSpider
Copy link
Contributor

No description provided.

@WebSpider WebSpider added the dependencies Pull requests that update a dependency file label Jan 13, 2025
@prvakt
Copy link
Collaborator

prvakt commented Jan 13, 2025

we have changed window_heating_state to be default = None so WindowHeatingSwitch must be updated

    def is_on(self) -> bool | None:  # noqa: D102
        if ac := self.vehicle.air_conditioning:
            if window_heating_state := ac.window_heating_state:
                return (
                    window_heating_state.front == OnOffState.ON
                    or window_heating_state.rear == OnOffState.ON
                )

@WebSpider WebSpider requested review from dvx76 and prvakt January 13, 2025 16:01
prvakt
prvakt approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@prvakt prvakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WebSpider WebSpider merged commit 8339bbe into skodaconnect:main Jan 14, 2025
3 checks passed
@WebSpider WebSpider deleted the bump-myskoda-0.17.2 branch January 29, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prvakt prvakt prvakt approved these changes

@dvx76 dvx76 Awaiting requested review from dvx76

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebSpider @prvakt